Add support for custom Helm chart repo, URL, and service name in installer scripts #1305
+2,425
−905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I like the addition of being able to apply custom overrides via a configuration file. Please extend this capability to all install-.sh scripts before we merge it into the main branch. |
…installer scripts Extend this capability to all install-.sh scripts before merging it into the main branch and converted mariadb & memcached installer to support dynamic variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the installer scripts to allow dynamic configuration of Helm chart repository name, repository URL, and service name through custom Helm override files.
Changes Introduced
repo_url,repo_name,service_name) from YAML files located under${SERVICE_CUSTOM_OVERRIDES}.Automatically detects OCI-based Helm registries (
oci://)Falls back to traditional Helm repo handling with
helm repo addandhelm repo update.Benefits