-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
backend: add region option in iCloud Drive to fix #8257 #8818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timerring
wants to merge
2
commits into
rclone:master
Choose a base branch
from
timerring:region-icloud-8257
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
It works for users who are using icloud in Mainland China. And I keep the same style of cli option and corresponding config. |
Author
|
Wait a moment. I will revise the corresponding document. |
Author
|
All done, request for review. Thanks @ncw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
The purpose of this change is to officially add support for iCloud Drive accounts in Mainland China (GCBD) to rclone’s iCloud Drive backend.
Previously, rclone’s iCloud Drive integration only hardcoded URLs for global iCloud servers (e.g., https://www.icloud.com), which caused fatal HTTP 302 errors when users with Mainland China Apple IDs attempted to connect—since Mainland China iCloud relies on independent .cn-suffixed servers (e.g., https://www.icloud.com.cn).
Was the change discussed in an issue or in the forum before?
Fixes #8257
As discussed in Issue, given the maintainer’s limited environment, I followed the instruction to add a new region option for iCloud Drive and test it. This option now works for users in Mainland China, and the relevant logs are attached below.
Checklist