add eslint #185
Open
add eslint #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update master
abdennour
requested changes
Dec 20, 2021
Collaborator
abdennour
left a comment
There was a problem hiding this comment.
please:
- Fix package.json
- Resolve conflicts with master
- Add Github action in ci.yaml workflow to run lint before everything.
| "homepage": "https://github.com/react-csv/react-csv#readme", | ||
| "dependencies": { | ||
| "react": "^15.5.4", | ||
| "prop-types": "15.7.2" |
Collaborator
There was a problem hiding this comment.
dependencies should be always empty.
Use devDependencies instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.