feat: deprecate string usage in Convert To List with warning #5539
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SoulSniper1212 <[email protected]>
Member
|
Thanks for the PR. As you can read from the issue, we haven't yet decided do we want to do this and my current thinking is no. In that case this PR will be closed. Otherwise tests are needed and the included log files should be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses issue #5538 by deprecating the usage of strings with the
Convert To Listkeyword in the Collections library. A deprecation warning is now issued when a string is passed to this keyword, directing users to useSplit String To Charactersfrom the String library instead.Checklist
Proof
The changes introduce a deprecation warning when the
Convert To Listkeyword receives a string input. This will guide users to use the more appropriateSplit String To Characterskeyword from the String library, improving clarity and preventing potential misuse.Closes
#5538