Hi, thank you for this. Can you please tell me how you updated msgpack ? The diff is too big to review, and the only way I can decently merge this PR while making sure there is no malicious code in there is to do the update myself and check that I end up in the same state as your branch.

I noticed you replaced "msgpack-c" with "clmdep_msgpack-c" so I suppose that code does not comes from the official msgpack repository. Is there a reason for that ? I would really prefer to stick with the official msgpack code.

Hi, thank you for this. Can you please tell me how you updated msgpack ? The diff is too big to review, and the only way I can decently merge this PR while making sure there is no malicious code in there is to do the update myself and check that I end up in the same state as your branch.

I noticed you replaced "msgpack-c" with "clmdep_msgpack-c" so I suppose that code does not comes from the official msgpack repository. Is there a reason for that ? I would really prefer to stick with the official msgpack code.

Sorry for late reply. It is used from official msgpack repository only. For consistency, i had to change it to clmdep_msgpack-c as being done for previous version of msgpack.

Has this been merged? Thanks.

No, I cannot realistically review this change, and I can't just trust the author that everything is sound and well-intentionned (no offense, that's just what's expected of a maintainer).

That being said, I'd like to see this merged but I need a way to be confident the upgrade is correct. Can you please provide a script performing the upgrade from the previous version to this one ? This way I can simply review the script, run it myself and check that the diff is identical to this PR.