perf: optimize session management with lock_guard and move semantics #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
std::unique_lock<std::mutex>withstd::lock_guard<std::mutex>in the accept handler since deferred locking is not needed.std::move(s)) when pushing the session into the container to avoid unnecessaryshared_ptrcopies.Why
lock_guardis lighter thanunique_lockand more suitable for this frequent operation (accepting connections).Modified Files
Lib/rpc/server.cc(thestart_acceptmethod)Testing