Store snapshot info date as Date instead of String to address issue on www.ruby-lang.org #15147
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
🙏 Thanks for your work. I forgot to say "Thank you!" at ruby/www.ruby-lang.org#3672 (comment) I will confirm this behavior later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the knowledgeable guidance of this PR comment from @hsbt, who has a deep understanding of the entire workflow, I traced the origin of an issue in the generated data files for ruby/www.ruby-lang.org to the
make-snapshottool here.The issue (see ruby/www.ruby-lang.org#3672 and all its ancestors) is that the resulting YAML block from
make-snapshot, which then flows in the_data/releases.yml, generates the release date as aString(usingstrftime) instead of aDateobject.This string is then persisted as is in the YAML downstream, breaking consistency with the other date objects and requiring a manual fix to remove the quotes and hence converting in a YAML Date object.
I believe this should be just a simple fix like the one proposed in this PR, but since I'm not sure of all the places these workflows could be used, let me know if the change is acceptable.
Thanks @hsbt for pointing me in the right direction.