Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoid allocating intermediate string in zone_str #15198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2025
Merged

Avoid allocating intermediate string in zone_str #15198

merged 1 commit into from
Nov 16, 2025
+5 −5

Conversation

@jhawthorn
Copy link
Member

@jhawthorn jhawthorn commented Nov 15, 2025 

compare-ruby: ruby 4.0.0dev (2025-11-14T22:32:35Z master 4ab0e89011) +PRISM [x86_64-linux]
last_commit=Revert "Avoid allocating intermediate string in zone_str"
built-ruby: ruby 4.0.0dev (2025-11-14T23:43:11Z master d9b6ea068c) +PRISM [x86_64-linux]
last_commit=Avoid allocating intermediate string in zone_str
warming up...
# Iteration per second (i/s)

|                        |compare-ruby|built-ruby|
|:-----------------------|-----------:|---------:|
|Time.now                |     14.917M|   14.481M|
|                        |       1.03x|         -|
|Time.now(in: "+09:00")  |      2.558M|    2.552M|
|                        |       1.00x|         -|
|Time.now.year           |      3.551M|    4.393M|
|                        |           -|     1.24x|

@launchable-app

This comment has been minimized.

Sign in to view
@nobu
Copy link
Member

nobu commented Nov 15, 2025

Not only failures in test-spec, probably the fstring table is broken.

@jhawthorn
Copy link
Member Author

jhawthorn commented Nov 15, 2025

Not only failures in test-spec, probably the fstring table is broken.

Problem was I confused rb_fstring_enc_new (which is only for literals) with rb_enc_interned_str (which copies the input)

@jhawthorn jhawthorn merged commit bdeee70 into ruby:master Nov 16, 2025
88 checks passed
@jhawthorn jhawthorn deleted the time_fstr branch November 16, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jhawthorn @nobu