ios screen sharing #12249
ios screen sharing #12249
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR integrates iOS screen sharing and audio capture support into the existing server, scrap, and Flutter layers. Key changes include:
- Added an iOS-specific audio service implementation in
audio_service.rs. - Extended the
scraplibrary with an iOS FFI and native ReplayKit-based capture. - Updated Flutter UI and model code to handle iOS permissions, settings, and conditionals.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/server/audio_service.rs | Added #[cfg(target_os = "ios")] audio service |
| src/platform/ios.rs | New stubs for platform-level iOS APIs |
| libs/scrap/src/lib.rs | Enabled scrap::ios module |
| libs/scrap/src/ios/ffi.rs | FFI layer with callback and polling buffer |
| flutter/lib/mobile/pages/settings_page.dart | Conditional UI tweaks for Android/iOS |
| flutter/lib/mobile/pages/server_page.dart | Calls to checkIOSPermission, updated notification text |
| flutter/lib/models/server_model.dart | checkIOSPermission and _restartServiceForAudio |
| showServerSettings(gFFI.dialogManager); | ||
| }), | ||
| if (!isIOS && !_hideNetwork && !_hideProxy) | ||
| if (!_hideNetwork && !_hideProxy) |
There was a problem hiding this comment.
The proxy settings section no longer excludes iOS, causing proxy options to appear on iOS where they should be hidden. Reinstate an isAndroid guard or add an isIOS exclusion to prevent iOS from showing proxy UI.
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| children: [ | ||
| Text(translate("android_start_service_tip"), | ||
| Text(translate(isAndroid ? "android_start_service_tip" : "Start screen sharing service"), |
There was a problem hiding this comment.
[nitpick] The fallback string for iOS is a hard-coded literal rather than a translation key. Consider adding a localized key for consistency and future translations.
| Text(translate(isAndroid ? "android_start_service_tip" : "Start screen sharing service"), | |
| Text(translate(isAndroid ? "android_start_service_tip" : "ios_start_service_tip"), |
| } | ||
|
|
||
| lazy_static::lazy_static! { | ||
| static ref TEMP_BUFFER: Mutex<Vec<u8>> = Mutex::new(vec![0u8; 4096 * 2160 * 4]); |
There was a problem hiding this comment.
The fallback buffer is statically sized for 4Kx2K RGBA and may be insufficient or wasteful for other resolutions. Consider resizing or reallocating the buffer based on actual get_display_info() dimensions to avoid over-allocating or truncated frames.
| static ref TEMP_BUFFER: Mutex<Vec<u8>> = Mutex::new(vec![0u8; 4096 * 2160 * 4]); | |
| static ref TEMP_BUFFER: Mutex<Vec<u8>> = { | |
| let (width, height) = get_display_info(); | |
| Mutex::new(vec![0u8; (width * height * 4) as usize]) | |
| }; |
| } | ||
|
|
||
| /// Check iOS permissions for screen recording and microphone | ||
| checkIOSPermission() async { |
There was a problem hiding this comment.
[nitpick] The async method has no explicit return type. For clarity and type safety, declare it as Future<void> checkIOSPermission() async { ... }.
| checkIOSPermission() async { | |
| Future<void> checkIOSPermission() async { |
|
This merge need check because it make basic issues |
No description provided.