fix: wayland, rdp, simualte lock keys #9653
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fufesou <[email protected]>
Owner
|
This PR is pending, because it is not really better than old. Both have big problem. Both have problem if local status not equal to remote, though this one seems a bit better (can work, but can not ensure local capslock status same to remote). We need smarter solution |
Contributor
|
What about implementing a VirtualLockState system that manages lock states independently of physical keyboard LED indicators? |
Contributor
|
@fufesou in each tab to be button of capslock and numlock and with virtual key management it will stay for each session |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8760
#9641
CapsLockandNumLockto the controlled side if it is Linux.(1)
Waylandrdp input: handle theCapsLockandNumLockkey events and ignore the lock states within the key events.(2) X11 or
Waylanduinput: handle the lock states within the key events and ignore theCapsLockandNumLockkey events.Note: There's also a side effect that the led may be changed after the remote control. The same to #9641
Tests
Windows -> Linux, "Map mode" and "Translate mode"
TODO