-
-
Notifications
You must be signed in to change notification settings - Fork 26.4k
DOC add paragraph on "AI usage disclosure" to Automated Contributions Policy and PR Template #32566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…icy and PR Template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AnneBeyer , looks good! Just not sure how best to put the 'select one of the following' part.
| We agree that AI can be a useful development assistant, but the use of any kind of | ||
| AI assistance has to be disclosed as per our Automated Contributions Policy | ||
| (see https://scikit-learn.org/dev/developers/contributing.html#automated-contributions-policy). | ||
| Please select one of the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this does not get rendered in a PR in github. We could take it out of the <!-- --> and just have bullet check marks (* [ ]) and ask them to select the appropriate one?
Not sure on this, open to other suggestions.
Co-authored-by: Lucy Liu <[email protected]>
doc/developers/contributing.rst
Outdated
| We agree that AI can be a useful development assistant, but the use of any kind of | ||
| AI assistance has to be disclosed in the PR description. Not doing so is not only | ||
| rude to the human maintainers, it also makes it diffictult to determine how much | ||
| scrutiny needs to be applied to the contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd make this shorter and more of a statement without opinion (e.g. is or isn't AI useful).
For example "If you use AI tools please state so in your Pull Request description."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can make it shorter, but should this also become more of a "please do so", or keep the stricter tone? Or should we even be more explicit on the consequences, like in the paragraph above on fully-automatic submissions ("Maintainers reserve the right, at their sole discretion, to close such submissions")?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. I like being polite.
I also like to try and keep it short because no one reads anything, and the longer the text the less people read it :-/
Reference Issues/PRs
First draft towards extending the Automated Contributions Policy for PRs to require a disclosure of AI usage, as discussed towards the end of #31679
What does this implement/fix? Explain your changes.
Adds a paragraph on required disclosure of AI usage to the Automated Contributions Policy and extends the PR template with a selection accordingly.
AI usage disclosure
(Though it could be useful to play around with different formulations/AI suggestions in this case...)
Any other comments?
Any comments/suggestions on the wording are welcome!