-
-
Notifications
You must be signed in to change notification settings - Fork 26.4k
CI Pin pytest<9 in wheels #32688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Pin pytest<9 in wheels #32688
Conversation
| # Dot the Python version for identifying the base Docker image | ||
| PYTHON_DOCKER_IMAGE_PART=$(echo ${PYTHON_VERSION:0:1}.${PYTHON_VERSION:1:2}) | ||
|
|
||
| # TODO Remove this when Python 3.14 is released and there is a Docker image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really related to pytest<9 ... I can move it to a separate PR if someone insists 🙄.
|
I'd be ok to merge this to get wheels and stuff working again. We can directly open a PR that undoes the pin again so we don't forget. |
|
I'm surprised we don't also have to introduce the |
|
OK let's merge this one to get the wheels green again! We'll see when pytest does a 9.0.1 with the revert.
We may need to add |
|
The lockfiles is what I meant. Can you tell I don't keep the information where exactly I need to go to influence them loaded in RAM? :D |
|
The wheels build worked fine this morning 🎉 https://github.com/scikit-learn/scikit-learn/actions/runs/19285781661 |
|
FWIW I wouldn't do anything about the lock-files yet. It seems like pytest is preparing a 9.0.1 release pytest-dev/pytest#13938 which should happen soonish and has the revert of the |
Work-around for #32393 (comment).
See pytest-dev/pytest#13895 for the pytest issue,
raise unittest.SkipTestraises in pytest 9.0 released on November 8.Could be a temporary work-around depending how fast pytest merges pytest-dev/pytest#13912 and do a new release.