Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lesteve
Copy link
Member

@lesteve lesteve commented Nov 10, 2025

Work-around for #32393 (comment).

See pytest-dev/pytest#13895 for the pytest issue, raise unittest.SkipTest raises in pytest 9.0 released on November 8.

Could be a temporary work-around depending how fast pytest merges pytest-dev/pytest#13912 and do a new release.

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: e157f88. Link to the linter CI: here

# Dot the Python version for identifying the base Docker image
PYTHON_DOCKER_IMAGE_PART=$(echo ${PYTHON_VERSION:0:1}.${PYTHON_VERSION:1:2})

# TODO Remove this when Python 3.14 is released and there is a Docker image
Copy link
Member Author

@lesteve lesteve Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really related to pytest<9 ... I can move it to a separate PR if someone insists 🙄.

@lesteve lesteve added the Quick Review For PRs that are quick to review label Nov 10, 2025
@betatim
Copy link
Member

betatim commented Nov 11, 2025

I'd be ok to merge this to get wheels and stuff working again. We can directly open a PR that undoes the pin again so we don't forget.

@betatim
Copy link
Member

betatim commented Nov 11, 2025

I'm surprised we don't also have to introduce the <9 limit in _min_dependencies.py

@lesteve
Copy link
Member Author

lesteve commented Nov 11, 2025

OK let's merge this one to get the wheels green again!

We'll see when pytest does a 9.0.1 with the revert.

I'm surprised we don't also have to introduce the <9 limit in _min_dependencies.py

We may need to add pytest<9 in build_tools/update_environment_and_lock_files.py if we want to be able to update lock-files again. There is less pressure to do this, since thanks to the beauty of lock-files, most of our CI is not affected by the pytest 9.0 change.

@lesteve lesteve merged commit a444d5c into scikit-learn:main Nov 11, 2025
78 checks passed
@betatim
Copy link
Member

betatim commented Nov 11, 2025

The lockfiles is what I meant. Can you tell I don't keep the information where exactly I need to go to influence them loaded in RAM? :D

@lesteve lesteve deleted the pytest-8-wheels branch November 12, 2025 07:45
@lesteve
Copy link
Member Author

lesteve commented Nov 12, 2025

The wheels build worked fine this morning 🎉 https://github.com/scikit-learn/scikit-learn/actions/runs/19285781661

@lesteve
Copy link
Member Author

lesteve commented Nov 12, 2025

FWIW I wouldn't do anything about the lock-files yet.

It seems like pytest is preparing a 9.0.1 release pytest-dev/pytest#13938 which should happen soonish and has the revert of the raise unittest.SkipTest breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build / CI Quick Review For PRs that are quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants