MNT: trees/forests/GBT: deprecate "friedman_mse" criterion
#32708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakedev0
commented
Nov 14, 2025
Comment on lines
+1128
to
+1129
| Training using "absolute_error" is significantly slower | ||
| than when using "squared_error". |
Contributor
Author
There was a problem hiding this comment.
Unrelated to this PR, but now that MAE criterion is at much 10x slower than the MSE, and usually more like 5x slower. Is it really significantly slower? It will still fit fairly fast for most tabular datasets (less than let's say 10M points).
"friedman_mse" criterion
cakedev0
commented
Nov 14, 2025
Comment on lines
+1554
to
1555
| @pytest.mark.skip("Skip for now") | ||
| def test_huber_exact_backward_compat(): |
Contributor
Author
There was a problem hiding this comment.
I propose to delete this test, as the changes proposed by this PR are not exactly backward compatible, given that the criterion calculations now use a different but equivalent formula.
Another option would be to update it with the current values, but I feel that a such test prevents legitimate changes/improvements that slightly affect any calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #32700 (deprecation before complete removal).
What does this implement/fix? Explain your changes.
FriedmanMSE(MSE)insklearn/tree/_criterion.pyx"friedman_mse"for trees & forests (if criterion="friedman_mse": criterion="squared_error"+ deprecation warning)criterionparam for gradient boosting