Fix memory leak in CaffeineCacheManager static mode #35821
+71
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b86be0c to
8e43a3f
Compare
When setCacheNames() is called to switch from dynamic to static mode, dynamically created caches were not removed from the internal cacheMap, causing: 1. Memory leak (orphaned cache references) 2. Violation of Javadoc contract stating cache names will be 'fixed' 3. getCacheNames() returning unexpected cache names This fix ensures that dynamically created caches are cleared when switching to static mode, while preserving custom caches registered via registerCustomCache(). Signed-off-by: ParkJuhyeong <[email protected]>
8e43a3f to
47706be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a memory leak in
CaffeineCacheManagerwhere dynamically created caches were not removed when switching to static mode viasetCacheNames().Changes
Core Fix
CaffeineCacheManager.setCacheNames()to clear dynamically created caches while preserving custom cachesTests Added
setCacheNamesShouldRemovePreviousDynamicCaches(): Verifies dynamic caches are clearedsetCacheNamesShouldPreserveCustomCaches(): Ensures custom caches are not affectedswitchingBetweenDynamicAndStaticMode(): Tests mode transitionsBackward Compatibility
This is a potentially breaking change for users who rely on the (undocumented) behavior of dynamic caches persisting after
setCacheNames().However: