Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add DeleteGenerator for MariaDB #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add DeleteGenerator for MariaDB #1275

wants to merge 3 commits into from

Conversation

@Mohab-Sobhy
Copy link

@Mohab-Sobhy Mohab-Sobhy commented Sep 18, 2025

Summary

This PR adds support for generating DELETE statements in MariaDB.

Changes

  • Added MariaDBDeleteGenerator for creating random DELETE queries.
  • Integrated the new DELETE action into MariaDBProvider.
  • Simplified imports in MariaDBProvider (import sqlancer.mariadb.gen.*).

@hawkingrei
Copy link
Collaborator

hawkingrei commented Oct 8, 2025 

 Error:  Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.20.0:validate (eclipseformat) on project sqlancer: File '/home/runner/work/sqlancer/sqlancer/src/sqlancer/mariadb/gen/MariaDBDeleteGenerator.java' has not been previously formatted. Please format file (for example by invoking `mvn net.revelc.code.formatter:formatter-maven-plugin:2.20.0:format`) and commit before running validation! -> [Help 1]

Please run mvn formatter:format to fix the linter.

@mrigger
Copy link
Contributor

mrigger commented Nov 2, 2025

Thanks for the PR! Feel free to ping us for reviews (at least I don't get automatic notifications).

Based on the CI/CD checks, the change causes some tests to fail. Could you please take a look?

@Mohab-Sobhy
Copy link
Author

Mohab-Sobhy commented Nov 2, 2025

@mrigger Thanks for the feedback!

I’ve addressed the Checkstyle and MariaDB issues, and the corresponding General tests and DBMS Tests (MariaDB) should now be fixed.

Some of the required checks (e.g., Materialize, TiDB, YugabyteDB) don’t appear to be related to my changes. For instance, the Materialize job fails during setup with the following error:

ERROR: syntax error at or near "SETTING"
LINE 1: SET CLUSTER SETTING sql.stats.forecasts.enabled = false

This seems to be an environment or version issue in the CI setup rather than something caused by the changes in the MariaDB generator.
Could you please confirm if that’s expected or if I should investigate further?

mrigger
mrigger reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

@mrigger mrigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, it seems the current CI tests are not failing for MariaDB. I remember checking and seeing a DELETE statement fail for MariaDB, but perhaps that was for another PR or got resolved.

I noticed another minor issue. After fixing it, we can merge the PR. Thanks!

src/sqlancer/mariadb/MariaDBProvider.java
case CREATE_INDEX:
nrPerformed = globalState.getRandomly().getInteger(0, 2);
break;
case DELETE:
Copy link
Contributor

@mrigger mrigger Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could also generate them with a low probability? This logic will include 10 DELETE statements into every test case, rather than probabilistically generate some for some test cases, so tables are likely to be empty for many test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrigger mrigger mrigger left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mohab-Sobhy @hawkingrei @mrigger