Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: ensure datetime uses nano seconds #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: ensure datetime uses nano seconds #529

wants to merge 4 commits into from
+167 −52

Conversation

@YuriZmytrakov
Copy link
Collaborator

@YuriZmytrakov YuriZmytrakov commented Nov 14, 2025 •
edited
Loading

Description:

Change datetime field type from date to date_nanos to ensure millisecond precision in datetime filter instead of truncation, for example 024999Z becomes 024Z. Also enforce 1970-2262 date boundaries required by the date_nanos resolution.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@YuriZmytrakov YuriZmytrakov marked this pull request as draft November 14, 2025 12:54
@YuriZmytrakov YuriZmytrakov marked this pull request as ready for review November 14, 2025 13:15
jonhealy1
jonhealy1 requested changes Nov 15, 2025
View reviewed changes
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good but I think this should be an optional feature. Can we enable it with an env var? Users could theoretically have data that precedes 1970 I think. We could even turn on nanosecond support by default but give users the option to use the old system, if they choose.

@YuriZmytrakov YuriZmytrakov force-pushed the CAT-1449-v2 branch 5 times, most recently from 86c95fe to 3ad2c7d Compare November 15, 2025 22:32
@YuriZmytrakov
Copy link
Collaborator Author

YuriZmytrakov commented Nov 16, 2025

This looks really good but I think this should be an optional feature. Can we enable it with an env var? Users could theoretically have data that precedes 1970 I think. We could even turn on nanosecond support by default but give users the option to use the old system, if they choose.

I added the USE_DATETIME_NANOS environment variable, which enables nanosecond precision. When it’s disabled, the system falls back to microsecond precision.

jonhealy1
jonhealy1 approved these changes Nov 17, 2025
View reviewed changes
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonhealy1 jonhealy1 jonhealy1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YuriZmytrakov @jonhealy1