fix: adaptive retry on aws #1917
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Added environment variables to both "Build AMI stage 1" and "Build AMI stage 2" steps in
.github/workflows/testinfra-ami-build.yml:111,120:
env:
AWS_MAX_ATTEMPTS: 10
AWS_RETRY_MODE: adaptive
What This Does
- Backs off exponentially on throttling errors
- Adapts retry timing based on AWS response patterns
- Handles transient network issues (like your "unexpected EOF")
- Works with rate limiting and temporary connectivity problems
Expected Impact
The frequent "unexpected EOF" was tied many times to a specific interaction with aws that doesn't require a full re-run of workflow