Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Test against clickhouse lts on CI #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2025
Merged

Test against clickhouse lts on CI #4589

merged 1 commit into from
Nov 16, 2025
+2 −2

Conversation

@Aaron1011
Copy link
Member

@Aaron1011 Aaron1011 commented Nov 13, 2025 •
edited by ellipsis-dev bot
Loading

Important

Update CI workflows to test against ClickHouse LTS version instead of 25.9, with conditional logic for merge group events.

  • CI Configuration:
    • Update clickhouse_version to use LTS version in general.yml and ui-tests.yml.
    • Conditional logic for clickhouse_version based on merge_group event.
  • Files Affected:
    • .github/workflows/general.yml: Adjusts ClickHouse version matrix.
    • .github/workflows/ui-tests.yml: Updates ClickHouse version for UI tests.

This description was created by Ellipsis for d77cc86. You can customize this summary. It will automatically update as commits are pushed.

Copilot AI review requested due to automatic review settings November 13, 2025 14:47
Copilot finished reviewing on behalf of Aaron1011 November 13, 2025 14:49
Copilot AI reviewed Nov 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ClickHouse version testing strategy to use the "lts" (Long Term Support) tag instead of the specific "24.12" version for merge group CI runs.

Key Changes

  • Replace ClickHouse version "24.12" with "lts" tag in merge group test matrices
  • Maintain "25.9" as the non-merge-group test version

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/ui-tests.yml Update UI tests matrix to test against ClickHouse "lts" instead of "24.12" when running in merge groups
.github/workflows/general.yml Update ClickHouse tests matrix to test against ClickHouse "lts" instead of "24.12" when running in merge groups

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

TensorZero CI Bot Automated Comment

CI is failing due to an external infrastructure/network issue with Namespace (nscloud) rather than a problem in this PR’s code or workflows.

Evidence:

  • The failing step in all red jobs is “Install Namespace CLI,” specifically at the “nsc docker login” call.
  • Logs show i/o timeouts to Namespace’s EU endpoint:
  • Because the Namespace login failed, downstream steps (Build gateway/ui container, docker-compose checks, and the “check-all-general-jobs-passed” aggregator) either skipped or hard-failed.

Nothing in this PR’s repo code or the recent workflow matrix change (adding ClickHouse “lts” for merge-group runs) affects Namespace connectivity. This looks like a transient outage or networking issue on Namespace’s side. Once Namespace is reachable, a simple rerun should pass.

Recommended next step:

  • Retry the failed jobs/rerun the workflow. If Namespace’s endpoint is back to normal, CI should go green without any code changes.

Optional follow-ups (outside the scope of this PR):

  • If this kind of outage recurs, we may consider adding retry/backoff on the nscloud login step or a fallback region, but that would require editing GitHub Actions, which we’re not changing here.

Try running the following commands to address the issues:

# Using GitHub CLI to rerun the latest failed run on this branch
RUN_ID=$(gh run list --branch aaron/clickhouse-lts --status failure --limit 1 --json databaseId -q '.[0].databaseId') && \
gh run rerun "$RUN_ID" --failed && \
gh run watch "$RUN_ID"

@virajmehta virajmehta added this pull request to the merge queue Nov 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2025
@Aaron1011 Aaron1011 added this pull request to the merge queue Nov 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2025
@Aaron1011 Aaron1011 added this pull request to the merge queue Nov 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2025
@virajmehta virajmehta added this pull request to the merge queue Nov 16, 2025
Merged via the queue into main with commit 961cb5a Nov 16, 2025
75 of 79 checks passed
@virajmehta virajmehta deleted the aaron/clickhouse-lts branch November 16, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@virajmehta virajmehta virajmehta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Aaron1011 @virajmehta