Use fresh ClickHouse db for test_count_datasets #4606
Merged
+17
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents concurrent test executions from affecting the final count
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR isolates the test_count_datasets test by using a fresh ClickHouse database, preventing concurrent test executions from affecting the dataset count. This ensures the test can reliably verify the expected behavior without interference from other tests.
Key Changes:
- Uses
get_clean_clickhouse()instead of the sharedget_clickhouse()to create an isolated test database - Manually runs migrations on the fresh database
- Updates assertions to expect exact counts (0 initially, 2 after insertions) instead of relative counts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
virajmehta
previously approved these changes
Nov 14, 2025
virajmehta
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents concurrent test executions from affecting the final count
Important
test_count_datasetsnow uses a fresh ClickHouse instance to prevent interference from concurrent test executions, ensuring accurate dataset count verification.test_count_datasetsnow uses a fresh ClickHouse instance viaget_clean_clickhouseto prevent interference from concurrent test executions.get_clean_clickhouseintest_count_datasetsto ensure a clean database state.migration_manager::runwithRunMigrationManagerArgsintest_count_datasets.This description was created by
for 7ff0715. You can customize this summary. It will automatically update as commits are pushed.