Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(eslint-plugin): [no-unused-private-class-members] new extension rule #11598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat(eslint-plugin): [no-unused-private-class-members] new extension rule #11598

wants to merge 2 commits into from

Conversation

@Zamiell
Copy link
Contributor

@Zamiell Zamiell commented Sep 12, 2025 •
edited
Loading

PR Checklist

Overview

  • First I copied the base rule from ESLint.
  • Next, I converted it to TypeScript + made it pass the linter + ensured that all tests were still passing.
  • Then, I refactored the main logic into a separate function called processPrivateIdentifier such that it could be called from different kinds of nodes.
  • Then, I added the PropertyDefinition selector.
  • Finally, I added some basic tests. Since the logic is directly reused from the base rule, more Typescript-specific tests are probably superfluous.

(This is my 2nd attempt at this PR, the first one was here: #10265)

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Sep 12, 2025

Thanks for the PR, @Zamiell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 12, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ff0496f
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68c487437d27b400085ed36f
😎 Deploy Preview https://deploy-preview-11598--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 91 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Zamiell Zamiell changed the title no unused private class members feat(eslint-plugin): [no-unused-private-class-members] new extension rule Sep 12, 2025
@Zamiell Zamiell force-pushed the no-unused-private-class-members branch from 826da83 to a33465d Compare September 12, 2025 20:28
@nx-cloud
Copy link

nx-cloud bot commented Sep 12, 2025 •
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.

View your CI Pipeline Execution ↗ for commit ff0496f

Command Status Duration Result
nx test eslint-plugin --coverage=false ❌ Failed 5m 11s View ↗
nx test eslint-plugin ❌ Failed 4m 51s View ↗
nx run-many -t lint ✅ Succeeded 3m 9s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 9s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-12 20:57:23 UTC

@kirkwaiblinger
Copy link
Member

kirkwaiblinger commented Sep 12, 2025 •
edited
Loading

FYI @Zamiell before you put too much time into this, there is also #10913 which I think is pretty far along

@Zamiell
Copy link
Contributor Author

Zamiell commented Sep 12, 2025

Oh nice, I didn't see that. Thank you Kirk, I'll close this now.

@Zamiell Zamiell closed this Sep 12, 2025
@Zamiell Zamiell deleted the no-unused-private-class-members branch September 12, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rule proposal: no-unused-private-class-members

2 participants

@Zamiell @kirkwaiblinger