fix(typescript-estree): forbid invalid modifiers in object methods #11689

fisker · 2025-10-09T07:04:54Z

PR Checklist

Addresses an existing open issue: fixes Enhancement: Forbid invalid modifiers in object methods #11687
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

typescript-eslint · 2025-10-09T07:04:57Z

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-10-09T07:04:59Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`e52f52e`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68e7af756cb4920008db8d07
😎 Deploy Preview	https://deploy-preview-11689--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 1 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-10-09T07:06:36Z

View your CI Pipeline Execution ↗ for commit e52f52e

Command	Status	Duration	Result
`nx run-many -t lint`	✅ Succeeded	3m 15s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	1m 53s	View ↗
`nx run integration-tests:test`	✅ Succeeded	5s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	1s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	3s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	3s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run generate-configs`	✅ Succeeded	8s	View ↗
`Additional runs (29)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-10-09 13:01:48 UTC

…d properties

codecov · 2025-10-09T11:57:54Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.67%. Comparing base (de1fedb) to head (e52f52e).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11689   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files         518      518           
  Lines       52466    52466           
  Branches     8694     8693    -1     
=======================================
+ Hits        47571    47572    +1     
+ Misses       4881     4880    -1     
  Partials       14       14

Flag	Coverage Δ
unittest	`90.67% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/typescript-estree/src/check-modifiers.ts	`15.92% <100.00%> (+0.31%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fisker · 2025-10-09T12:58:14Z

packages/ast-spec/tests/fixtures-with-differences-errors.shot

+    "expression/ObjectExpression/fixtures/_error_/getter-modifier-declare/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/getter-modifier-export/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/getter-modifier-override/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/getter-modifier-private/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/getter-modifier-protected/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/getter-modifier-public/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/getter-modifier-static/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/property-modifier-abstract/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/property-modifier-async/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/property-modifier-declare/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/property-modifier-export/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/property-modifier-override/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/property-modifier-private/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/property-modifier-protected/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/property-modifier-public/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/property-modifier-static/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/setter-modifier-declare/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/setter-modifier-export/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/setter-modifier-override/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/setter-modifier-private/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/setter-modifier-protected/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/setter-modifier-public/fixture.ts",
+    "expression/ObjectExpression/fixtures/_error_/setter-modifier-static/fixture.ts",


Turns out there is something wrong in getModifiers() utility, I can't get all modifiers, so these are not easy to fix.

Let's keep these as TODO?

#11688 can be addressed in another PR.

JoshuaKGoldberg

Thanks!

fix(typescript-estree): forbid invalid modifiers in object methods an…

2fbf9d0

…d properties

fisker force-pushed the object-modifier branch 2 times, most recently from 16fcab8 to 995e312 Compare October 9, 2025 11:46

Test

995e312

Remove properties

f018c53

fisker changed the title ~~fix(typescript-estree): forbid invalid modifiers in object properties~~ fix(typescript-estree): forbid invalid modifiers in object methods Oct 9, 2025

fisker added 4 commits October 9, 2025 20:34

getters

7fa0f1f

setter

042ddf5

property

730f40f

Snapshots

e52f52e

fisker commented Oct 9, 2025

View reviewed changes

fisker marked this pull request as ready for review October 9, 2025 13:00

JoshuaKGoldberg approved these changes Oct 20, 2025

View reviewed changes

JoshuaKGoldberg merged commit 4eda303 into typescript-eslint:main Oct 20, 2025
69 checks passed

fisker deleted the object-modifier branch October 20, 2025 15:44

chrisbbreuer mentioned this pull request Oct 20, 2025

chore(deps): update all non-major dependencies stacksjs/eslint-plugin#67

Open

1 task

This was referenced Oct 21, 2025

Bump @typescript-eslint/parser from 8.46.0 to 8.46.2 fossas/fossa-action#229

Merged

Update dependency @typescript-eslint/parser to v8.46.2 ericcornelissen/js-regex-security-scanner#1281

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(typescript-estree): forbid invalid modifiers in object methods #11689

fix(typescript-estree): forbid invalid modifiers in object methods #11689

Uh oh!

fisker commented Oct 9, 2025 •

edited by JoshuaKGoldberg

Loading

Uh oh!

typescript-eslint bot commented Oct 9, 2025

Uh oh!

netlify bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

fisker Oct 9, 2025

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(typescript-estree): forbid invalid modifiers in object methods #11689

fix(typescript-estree): forbid invalid modifiers in object methods #11689

Uh oh!

Conversation

fisker commented Oct 9, 2025 • edited by JoshuaKGoldberg Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Oct 9, 2025

Uh oh!

netlify bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

fisker Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fisker commented Oct 9, 2025 •

edited by JoshuaKGoldberg

Loading

netlify bot commented Oct 9, 2025 •

edited

Loading

nx-cloud bot commented Oct 9, 2025 •

edited

Loading

codecov bot commented Oct 9, 2025 •

edited

Loading