Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(eslint-plugin): use correct type for return type of createValidator #11721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
+3 −8
Merged

chore(eslint-plugin): use correct type for return type of createValidator #11721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/eslint-plugin/src/rules/naming-convention-utils/validator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import type * as ts from 'typescript';
import { AST_NODE_TYPES } from '@typescript-eslint/utils';

import type { SelectorsString } from './enums';
import type { Context, NormalizedSelector } from './types';
import type { Context, NormalizedSelector, ValidatorFunction } from './types';

import { getParserServices } from '../../util';
import {
Expand All @@ -26,9 +26,7 @@ export function createValidator(
type: SelectorsString,
context: Context,
allConfigs: NormalizedSelector[],
): (
node: TSESTree.Identifier | TSESTree.Literal | TSESTree.PrivateIdentifier,
) => void {
): ValidatorFunction {
// make sure the "highest priority" configs are checked first
const selectorType = Selectors[type];
const configs = allConfigs
Expand Down Expand Up @@ -72,10 +70,7 @@ export function createValidator(
return b.selector - a.selector;
});

return (
node: TSESTree.Identifier | TSESTree.Literal | TSESTree.PrivateIdentifier,
modifiers: Set<Modifiers> = new Set<Modifiers>(),
): void => {
return (node, modifiers = new Set<Modifiers>()): void => {
const originalName =
node.type === AST_NODE_TYPES.Identifier ||
node.type === AST_NODE_TYPES.PrivateIdentifier
Expand Down
Loading