Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(eslint-plugin-internal): correct documentation URLs with undefined version #11736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(eslint-plugin-internal): correct documentation URLs with undefined version #11736

wants to merge 2 commits into from

Conversation

@azat-io
Copy link
Contributor

@azat-io azat-io commented Nov 3, 2025

Fixed broken documentation URLs in @typescript-eslint/eslint-plugin-internal rules that were showing vundefined in the path.

The internal plugin package is private and didn't have a version field in package.json, causing undefined to be interpolated into documentation URLs.

Before:

https://github.com/typescript-eslint/typescript-eslint/blob/vundefined/packages/eslint-plugin-internal/src/rules/no-dynamic-tests.ts

After:

https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin-internal/src/rules/no-dynamic-tests.ts

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Nov 3, 2025

Thanks for the PR, @azat-io!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Nov 3, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0909429
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/69093097c3d4b2000810a7ab
😎 Deploy Preview https://deploy-preview-11736--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 92 (🔴 down 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Nov 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 0909429

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 6s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 9s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 3s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 10s View ↗
nx run integration-tests:test ✅ Succeeded 4s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (29) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-11-03 22:52:19 UTC

@codecov
Copy link

codecov bot commented Nov 3, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.64%. Comparing base (ea2ee6b) to head (0909429).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11736      +/-   ##
==========================================
- Coverage   90.66%   90.64%   -0.02%     
==========================================
  Files         518      518              
  Lines       52435    52435              
  Branches     8686     8686              
==========================================
- Hits        47541    47532       -9     
- Misses       4880     4889       +9     
  Partials       14       14
Flag Coverage Δ
unittest 90.64% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kirkwaiblinger
kirkwaiblinger approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah, I'd been meaning to file an issue about this. Thanks for fixing!

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 5, 2025
@kirkwaiblinger kirkwaiblinger changed the title fix(eslint-plugin-internal): correct documentation URLs with undefined version chore(eslint-plugin-internal): correct documentation URLs with undefined version Nov 5, 2025
@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) November 10, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azat-io @kirkwaiblinger @JoshuaKGoldberg