Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support swapping directly with WETH #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Support swapping directly with WETH #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions tests/test_uniswap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,3 +330,30 @@ def test_make_trade_output(
balance_after = client.get_token_balance(output_token)
if output_token != self.eth:
assert balance_before + qty == balance_after

@pytest.mark.parametrize(
"input_token, output_token, route, expectation",
[
(dai, weth, [dai, weth], does_not_raise),
(weth, dai, [weth, dai], does_not_raise),
(usdc, dai, [usdc, weth, dai], does_not_raise),
(weth, eth, [], lambda: pytest.raises(ValueError)),
(eth, weth, [], lambda: pytest.raises(ValueError)),
],
)
def test_get_v2_trade_route(
self,
input_token,
output_token,
route,
expectation,
client
):
if client.version == 1:
pytest.skip(
"Not supported in this version of Uniswap, or at least no liquidity"
)
with expectation():
res = client._get_v2_trade_route(input_token, output_token)

assert res == route
23 changes: 20 additions & 3 deletions uniswap/uniswap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ def _get_token_token_output_price(
elif is_same_address(token1, self.get_weth_address()):
return int(self._get_token_eth_output_price(token0, Wei(qty), fee))

route = [token0, self.get_weth_address(), token1]
route = self._get_v2_trade_route(token0, token1)
logger.warning(f"No route specified, assuming route: {route}")

if self.version == 2:
Expand Down Expand Up @@ -558,11 +558,12 @@ def _token_to_token_swap_input(
input_token, output_token, qty, fee=fee
)
)
route = self._get_v2_trade_route(input_token, output_token)
return self._build_and_send_tx(
self.router.functions.swapExactTokensForTokens(
qty,
min_tokens_bought,
[input_token, self.get_weth_address(), output_token],
route,
recipient,
self._deadline(),
),
Expand Down Expand Up @@ -595,6 +596,22 @@ def _token_to_token_swap_input(
else:
raise ValueError

def _get_v2_trade_route(
self, input_token: AddressLike, output_token: AddressLike
) -> List[AddressLike]:
"""Gets trade route simply through WETH.

Deals with two special cases when trading directly with WETH.
"""
weth = self.get_weth_address()
if {weth, ETH_ADDRESS} == {input_token, output_token}:
raise ValueError("Swapping between ETH and WETH not supported!")
if input_token == weth:
return [weth, output_token]
elif output_token == weth:
return [input_token, weth]
return [input_token, weth, output_token]

def _eth_to_token_swap_output(
self,
output_token: AddressLike,
Expand Down Expand Up @@ -736,7 +753,7 @@ def _token_to_token_swap_output(
self.router.functions.swapTokensForExactTokens(
qty,
amount_in_max,
[input_token, self.get_weth_address(), output_token],
self._get_v2_trade_route(input_token, output_token),
recipient,
self._deadline(),
),
Expand Down