feat: include directives in injectionUsage metadata
#381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
==========================================
- Coverage 98.73% 97.65% -1.09%
==========================================
Files 14 15 +1
Lines 1817 1449 -368
Branches 374 459 +85
==========================================
- Hits 1794 1415 -379
- Misses 23 34 +11 ☔ View full report in Codecov by Sentry. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a new parameter in
Addon:transformfunction to allow collect directives ininjectionUsagemetadata.Right now there is no way to know what directives were used and so we cannot collect the info: we cannot use
getImportssince it can contains imports from other ids.This PR is about the pending task here: nuxt/devtools#740 (comment)
/cc @antfu
Can this be done with
injectImportsResolved? If so, I will change this PR to add it to thevue-directivesaddon.The problem is Nuxt where we have 2
unimportcontexts:importsanddirectives(we only reuse some configuration from Nuxtimportsoptions). We need to collect the imports fromdirectivescontext and update them in theimportscontext.Another problem is about custom directives injection, since there is no auto import, it is just a transform.
Nuxt PR on my local