[NIXL][XPU] update install script of NIXL #28778
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the installation script for NIXL and pins its version in the Dockerfile. The changes aim to improve the build process by using rpath to locate shared libraries, which is a good practice. However, I've found a critical issue in how the rpath is being set in the installation script, which will likely cause runtime failures. My review includes a suggested fix for this issue.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: zhenwei-intel <[email protected]>
7b8d9f4 to
9ee46b6
Compare
update install script of NIXL
pin to 0.7.0 in dockerfile