[BugFix] Fix async scheduling + chunked prefill + preemption #28787
+8
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Hill <[email protected]>
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug related to async scheduling, chunked prefill, and preemption. The core of the fix is in vllm/v1/core/sched/scheduler.py, where previously only a slice of token IDs was being sent for requests undergoing chunked prefill. This was incorrect as the connector requires the full list of tokens for prefix matching. The change correctly sends a full copy of the token IDs. To facilitate this, a copy() method was added to the ConstantList class. The re-enabling of previously skipped tests in tests/v1/e2e/test_async_scheduling.py validates the fix. The changes are correct, well-targeted, and I have no further recommendations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix, took a while to track down 😅