Thanks to visit codestin.com
Credit goes to GitHub.com

Skip to content

Update to xunit.v3 #26461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Youssef1313 wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Update to xunit.v3 #26461

Youssef1313 wants to merge 15 commits into from
+91 −149

Conversation

@Youssef1313
Copy link
Contributor

@Youssef1313 Youssef1313 commented Nov 16, 2025 •
edited
Loading

PR Summary

This PR updates from xunit 2 to xunit.v3.
Xunit 2 is no longer maintained and repos should move forward to xunit.v3.

PR Context

As mentioned in PR summary, this updates the repo to use xunit.v3 which is the maintained version of xunit.

PR Checklist

@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Nov 17, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 20, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Dec 5, 2025
@Youssef1313 Youssef1313 marked this pull request as ready for review December 5, 2025 14:25
@Youssef1313 Youssef1313 requested review from a team and jshigetomi as code owners December 5, 2025 14:25
Copilot AI review requested due to automatic review settings December 5, 2025 14:25
@Youssef1313
Copy link
Contributor Author

Youssef1313 commented Dec 5, 2025

@iSazonov Can you run the GitHub workflows here please?

Copilot AI reviewed Dec 5, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the PowerShell test infrastructure from xUnit v2 to xUnit v3, updates to .NET 10 stable SDK, and migrates to the Microsoft Testing Platform (MTP). The changes modernize the testing framework by replacing deprecated xUnit v2 patterns with v3 equivalents and simplifying test execution.

Key changes:

  • Migrates from xUnit v2 (version 2.x packages) to xUnit v3 using the xunit.v3.mtp-v2 unified package
  • Updates test attributes from SkippableFact/SkippableTheory to standard Fact/Theory with Assert.Skip* methods
  • Replaces priority-based test ordering with source declaration ordering

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/xUnit/xUnit.tests.csproj Consolidates multiple xUnit v2 packages into single xunit.v3.mtp-v2 package, adds OutputType, removes deprecated properties
test/hosting/hosting.tests.csproj Similar xUnit v3 migration with package consolidation
global.json Adds test runner configuration for Microsoft Testing Platform
test/xUnit/csharp/test_*.cs Migrates test attributes and skip conditions to xUnit v3 API (SkippableFact → Fact with Assert.Skip*)
test/xUnit/Asserts/PriorityOrderer.cs Replaces priority-based ordering with source declaration ordering for xUnit v3
test/xUnit/Asserts/PriorityAttribute.cs Removes deprecated priority attribute no longer needed in v3
build.psm1 Updates Start-PSxUnit to use MTP command-line arguments instead of legacy dotnet test logger

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@iSazonov iSazonov requested a review from Copilot December 11, 2025 18:00
Copilot AI reviewed Dec 11, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Dec 18, 2025
Youssef1313
Youssef1313 commented Jan 23, 2026
View reviewed changes
Youssef1313
Youssef1313 commented Jan 23, 2026
View reviewed changes
@iSazonov
Copy link
Collaborator

iSazonov commented Jan 23, 2026

@Youssef1313 Please resolve merge conflicts.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Jan 23, 2026
@kilasuit
Copy link
Collaborator

kilasuit commented Jan 26, 2026

@Youssef1313
Please update ALL of the required fields in the PR Template that have not yet been filled in.
Please also mark this as a draft if this PR is not yet in a state that is ready to be merged as to help the maintainers and other reviewers prioritise what should or should not be fully reviewed yet.
Also without all those fields filled out we really should not begin to think about merging a PR

@iSazonov as a maintainer you may want to add text similar to the above to your own Saved Replies setting in your profile for in future as would help ensure we have high quality PR's that properly detail and link to why we are doing the work.

@Youssef1313 Youssef1313 changed the title Update to xunit.v3, .NET 10 stable, and MTP Update to xunit.v3 Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jshigetomi jshigetomi Awaiting requested review from jshigetomi jshigetomi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Youssef1313 @iSazonov @kilasuit