Thanks to visit codestin.com
Credit goes to GitHub.com

Skip to content

refactor(docs-infra): adjustements #66822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
JeanMeche wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(docs-infra): adjustements #66822

JeanMeche wants to merge 1 commit into from
+1,821 −768

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Jan 29, 2026

No description provided.

@angular-robot angular-robot bot added the area: docs-infra Angular.dev application and infrastructure label Jan 29, 2026
@ngbot ngbot bot added this to the Backlog milestone Jan 29, 2026
@JeanMeche JeanMeche force-pushed the adev-homepage branch 3 times, most recently from 791208d to fb3c666 Compare January 29, 2026 14:09
@github-actions
Copy link

github-actions bot commented Jan 29, 2026 •
edited
Loading

Deployed adev-preview for 8c559ad to: https://ng-dev-previews-fw--pr-angular-angular-66822-adev-prev-lqdjn9c2.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche force-pushed the adev-homepage branch 3 times, most recently from 668aff1 to 361e583 Compare January 29, 2026 15:05
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jan 29, 2026
@JeanMeche JeanMeche force-pushed the adev-homepage branch 2 times, most recently from 471b68a to 5b4bd53 Compare January 29, 2026 15:20
hawkgs
hawkgs reviewed Jan 29, 2026
View reviewed changes
SkyZeroZx
SkyZeroZx reviewed Jan 29, 2026
View reviewed changes
@JeanMeche JeanMeche force-pushed the adev-homepage branch 4 times, most recently from 43ea6cc to b0dcc5b Compare January 29, 2026 16:32
@JeanMeche JeanMeche force-pushed the adev-homepage branch 3 times, most recently from d88352e to 658c6a6 Compare January 29, 2026 18:23
SkyZeroZx
SkyZeroZx reviewed Jan 29, 2026
View reviewed changes
adev/src/app/features/home/home.component.html
<div ngTabs class="material-tabs">
<div ngTabList selectionMode="follow" selectedTab="signals">
<div class="tab-background"></div>
<div ngTab value="signals">Signals</div>
Copy link
Contributor

@SkyZeroZx SkyZeroZx Jan 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some contrast issues in the tab

Image Image

Also we can see in pagespeed results the same issue
https://pagespeed.web.dev/analysis/https-ng-dev-previews-fw--pr-angular-angular-66822-adev-prev-lqdjn9c2-web-app/p1hwdm0ixw?form_factor=mobile

https://webaim.org/resources/contrastchecker/

This is only for light mode

@JeanMeche JeanMeche force-pushed the adev-homepage branch 3 times, most recently from a7b0c81 to df829c1 Compare January 30, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkgs hawkgs hawkgs left review comments

+1 more reviewer

@SkyZeroZx SkyZeroZx SkyZeroZx left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@JeanMeche @hawkgs @SkyZeroZx