[pipeline-manager] Treat missing hosts as 1 for update purposes.
#5543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value of `hosts` is 1, which means that attempting to set pipeline configuration in any way will populate it with 1 if it is not set, but the pipeline manager was rejecting as different a missing old `hosts` and a new `hosts` of 1, which meant that users effectively couldn't change any configuration at all without clearing storage. This fixes the problem. Signed-off-by: Ben Pfaff <[email protected]>
mihaibudiu
approved these changes
Jan 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the pipeline manager incorrectly rejected configuration updates when the old configuration had a missing hosts field and the new configuration set it to 1 (the default value). This was preventing users from updating pipeline configurations without clearing storage.
Changes:
- Modified the
hostscomparison logic to treat missing values as 1 (the default) - Added
serde_json::jsonimport to support the comparison
Comment on lines
+701
to
+703
| let one = json!(1); | ||
| if runtime_config.get("hosts").unwrap_or(&one) | ||
| != current.runtime_config.get("hosts").unwrap_or(&one) |
There was a problem hiding this comment.
The json!(1) value is created on every invocation but never changes. Consider defining this as a constant outside the function (e.g., lazy_static or const) to avoid repeated allocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of
hostsis 1, which means that attempting to set pipeline configuration in any way will populate it with 1 if it is not set, but the pipeline manager was rejecting as different a missing oldhostsand a newhostsof 1, which meant that users effectively couldn't change any configuration at all without clearing storage. This fixes the problem.