Fix schema transformation and Field Visibility for complex deletion cases #4209

andimarek · 2026-01-19T06:58:36Z

For certain complex schema deletion cases the current schema transformer fails.

This PR introduces a new transform method transformSchemaWithDeletes which should be used specifically for these cases.

The FieldVisibilityTransformer is also changed internally to use this new method.

The existing schema transformation was unchanged to keep existing behavior as the new transformSchemaWithDeletes changes slightly the traversal behavior.

The original bug was first reported in #4133, but we had additional reports after.

github-actions · 2026-01-19T07:00:38Z

Test Results

327 files ±0 327 suites ±0 5m 7s ⏱️ ±0s
5 230 tests +2 5 222 ✅ +3 8 💤 - 1 0 ❌ ±0
5 319 runs +2 5 311 ✅ +3 8 💤 - 1 0 ❌ ±0

Results for commit 6b77ff8. ± Comparison against base commit 2766087.

This pull request removes 213 and adds 191 tests. Note that renamed tests count towards both.

	?

	, expected: combo-\"\\\b\f\n\r\t, #4]
                __schema { types { fields { args { type { name fields { name }}}}}}
                __schema { types { fields { type { name fields { name }}}}}
                __schema { types { inputFields { type { inputFields { name }}}}}
                __schema { types { interfaces { fields { type { interfaces { name } } } } } }
                __schema { types { name} }
                __type(name : "t") { name }
                a1: __schema { types { name} }
                a1: __type(name : "t") { name }
…

graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure23@37b56ac7 delegate=graphql.AssertTest@43f9dd56 owner=graphql.AssertTest@43f9dd56 thisObject=graphql.AssertTest@43f9dd56 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure24@5399f6c5 delegate=graphql.AssertTest@43f9dd56 owner=graphql.AssertTest@43f9dd56 thisObject=graphql.AssertTest@43f9dd56 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure25@4fe64d23 delegate=graphql.AssertTest@43f9dd56 owner=graphql.AssertTest@43f9dd56 thisObject=graphql.AssertTest@43f9dd56 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure20@10db6131 delegate=graphql.AssertTest@43f9dd56 owner=graphql.AssertTest@43f9dd56 thisObject=graphql.AssertTest@43f9dd56 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure21@6c6017b9 delegate=graphql.AssertTest@43f9dd56 owner=graphql.AssertTest@43f9dd56 thisObject=graphql.AssertTest@43f9dd56 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure22@4730e0f0 delegate=graphql.AssertTest@43f9dd56 owner=graphql.AssertTest@43f9dd56 thisObject=graphql.AssertTest@43f9dd56 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure3@2abe9173 delegate=graphql.AssertTest@43f9dd56 owner=graphql.AssertTest@43f9dd56 thisObject=graphql.AssertTest@43f9dd56 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure4@354e7004 delegate=graphql.AssertTest@43f9dd56 owner=graphql.AssertTest@43f9dd56 thisObject=graphql.AssertTest@43f9dd56 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure5@6f231ced delegate=graphql.AssertTest@43f9dd56 owner=graphql.AssertTest@43f9dd56 thisObject=graphql.AssertTest@43f9dd56 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of error args with non null does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_6prov0_closure6@376c7d7d delegate=graphql.AssertTest@43f9dd56 owner=graphql.AssertTest@43f9dd56 thisObject=graphql.AssertTest@43f9dd56 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
…

♻️ This comment has been updated with latest results.

Change GraphQLSchema.additionalTypes from Set<GraphQLType> to Set<GraphQLNamedType> for improved type safety. All types that can be added as additional types are named types, so this makes the API more precise.

bbakerman · 2026-01-19T23:53:48Z

src/main/java/graphql/schema/GraphQLSchema.java

     * @see Builder#additionalTypes(Set)
     */
-    public Set<GraphQLType> getAdditionalTypes() {
+    public Set<GraphQLNamedType> getAdditionalTypes() {


This is a breaking change. Just in case you didnt realise.

bbakerman · 2026-01-19T23:54:05Z

src/main/java/graphql/schema/GraphQLSchema.java

+        public Builder additionalTypes(Set<? extends GraphQLNamedType> additionalTypes) {
            this.additionalTypes.addAll(additionalTypes);
            return this;
        }


also a breaking change

bbakerman · 2026-01-19T23:54:32Z

src/main/java/graphql/schema/GraphQLSchema.java

+        public Builder additionalType(GraphQLNamedType additionalType) {
            this.additionalTypes.add(additionalType);
            return this;
        }


and again - thats ok - just pointing it out

Well .. they never contained not named types so far. Technically breaking, but I think nobody ever used it to add [Foo] instead of Foo

bbakerman · 2026-01-19T23:55:52Z

I have labelled it as a breaking change because it it. Its in the minor category of possible impact but none the less Java breaking

add specific transform method for deletion cases

0464f19

andimarek added 7 commits January 19, 2026 17:02

explanation

bfd8789

Test to showcase bug

49dca7e

Refactor additionalTypes to use GraphQLNamedType

44aeed6

Change GraphQLSchema.additionalTypes from Set<GraphQLType> to Set<GraphQLNamedType> for improved type safety. All types that can be added as additional types are named types, so this makes the API more precise.

simplify

fe82d4f

handle deletion case much better on the schema transformer level

7c55747

handle deletion case much better on the schema transformer level

7553d76

add AGENTS.md

6b77ff8

andimarek changed the title ~~add specific transform method for deletion cases~~ Fix schema transformation for complex deletion cases Jan 19, 2026

andimarek changed the title ~~Fix schema transformation for complex deletion cases~~ Fix schema transformation and Field Visibility for complex deletion cases Jan 19, 2026

andimarek mentioned this pull request Jan 19, 2026

SchemaTransformer.transformSchema produces schema with dangling reference to deleted type #4133

Closed

bbakerman reviewed Jan 19, 2026

View reviewed changes

bbakerman approved these changes Jan 19, 2026

View reviewed changes

bbakerman added the breaking change requires a new major version to be relased label Jan 19, 2026

andimarek merged commit c225c59 into master Jan 20, 2026
5 checks passed

andimarek added this to the 26.x breaking changes milestone Jan 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix schema transformation and Field Visibility for complex deletion cases #4209

Fix schema transformation and Field Visibility for complex deletion cases #4209

andimarek commented Jan 19, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 19, 2026 •

edited

Loading

Uh oh!

bbakerman Jan 19, 2026

Uh oh!

bbakerman Jan 19, 2026

Uh oh!

bbakerman Jan 19, 2026

Uh oh!

andimarek Jan 19, 2026

Uh oh!

bbakerman commented Jan 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix schema transformation and Field Visibility for complex deletion cases #4209

Fix schema transformation and Field Visibility for complex deletion cases #4209

Conversation

andimarek commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

bbakerman Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

bbakerman Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

bbakerman Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

andimarek Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

bbakerman commented Jan 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andimarek commented Jan 19, 2026 •

edited

Loading

github-actions bot commented Jan 19, 2026 •

edited

Loading