Create external ssh process with flag CREATE_NO_WINDOW#7171
Open
Jonny007-MKD wants to merge 1 commit intolibgit2:mainfrom
Open
Create external ssh process with flag CREATE_NO_WINDOW#7171Jonny007-MKD wants to merge 1 commit intolibgit2:mainfrom
Jonny007-MKD wants to merge 1 commit intolibgit2:mainfrom
Conversation
Member
|
Is opening a window always a bad idea or should libgit2 make this an option? If someone were building a GUI, and the SSH executable needed to prompt for a passphrase, should we have a window in that instance? 🤔 |
Author
|
That's a good point. I haven't seen SSH itself ask for a password when used by Git since ages (typically a separate window of the Git Credential Manager or something else opens) but it definitely is not impossible. Where would such an option be placed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that a window (a terminal) is created when starting the ssh process to download data. The flag CREATE_NO_WINDOW avoids this.
https://learn.microsoft.com/en-us/windows/win32/procthread/process-creation-flags