gh-130148: Add redirect_stdout(..., per_thread: bool = False)
#144334
+439
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #130148, there was discussion of what would be required to make
redirect_stdoutthread-aware. #130148 (comment) proposed adding aper_thread: bool = Falseargument. This PR implements that argument.To support interleaving
per_thread=Falseandper_thread=True, this PR uses a slightly more complicated design involving walking up the stack of context managers to find the first one applicable to its thread.As an example motivating usage, making
doctestthread-safe becomes a ~one line change with this PR: https://github.com/python/cpython/compare/main...Liam-DeVoe:cpython:redirect-stdout-doctest?expand=1.I think there's been previous discussion of whether this should live in CPython or be proven out in another project first. I don't know exactly where people have fallen on this. I opened a previous version of this code against Quansight-Labs/pytest-run-parallel#167, but after discussion with @ngoldbaum it was unclear to us that pytest-run-parallel is the right place for this to live, rather than the standard library.
cc: @ngoldbaum @colesbury
pytest-run-parallel#130148