gh-140824: Fix _Py_DumpExtensionModules() to ignore sub-modules #144339
+37
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore "math.integer" extension if "math" is in sys.stdlib_module_names.
|
|
||
| @skip_segfault_on_android | ||
| def test_dump_ext_modules(self): | ||
| # Disable sys.stdlib_module_names |
Member
There was a problem hiding this comment.
This just duplicates the below, "Don't filter stdlib module names," IMO we don't need both.
Comment on lines
+421
to
+422
| match = re.search(r'^Extension modules:', stderr, re.MULTILINE) | ||
| self.assertIsNone(match) |
Member
There was a problem hiding this comment.
Suggested change
| match = re.search(r'^Extension modules:', stderr, re.MULTILINE) | |
| self.assertIsNone(match) | |
| self.assertNotIn('Extension modules:', stderr) |
Why not just so?
| @@ -0,0 +1,3 @@ | |||
| When :mod:`faulthandler` dumps the list of third-party extension modules, | |||
| ignore ``math.integer`` sub-module since ``math`` package is part of | |||
Member
There was a problem hiding this comment.
Can we be more general, e.g. "ignore sub-modules of packages in ..."? Otherwise it makes it seem like only the one specific case is affected.
| } | ||
| assert(key_len > len); | ||
|
|
||
| // Ignore "math.integer" if key starts with "math." |
Member
There was a problem hiding this comment.
Suggested change
| // Ignore "math.integer" if key starts with "math." | |
| // Ignore sub-modules of stdlib packages |
Same as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore "math.integer" extension if "math" is in
sys.stdlib_module_names.