Conversation
tjvr
commented
Apr 14, 2024
| // Center the label text inside reporters with short names. | ||
| // | ||
| // Scratch doesn't do this for lists for some reason?? | ||
| if (this.isReporter && this.info.category !== "list") { |
Member
Author
There was a problem hiding this comment.
I've made this "is not list" rather than "is variable or parameter" because it will only matter in the case of a very short e.g. Motion reporter block, and I'm not aware of any -- I'll update this if we find one (in a non-English language maybe)?
Contributor
There was a problem hiding this comment.
I don't know if I've made this clear or not but the (x) motion block is a real Scratch block, it's the (x position) block in Czech
Member
Author
There was a problem hiding this comment.
Oh good to know, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scratchblocks has always centered the labels inside reporters with short names. It turns out Scratch (by mistake?) left-aligns some reporters, including list reporters.
Closes #506.
Thanks to @husqwc for reporting!