feat(sqlite): Support NOT NULL constraints #4234
Open
+17
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@kyleconroy, polite bump. I'm basically trying to point you to a feature you may have missed, since not many bindings wrap the If that's inadequate, feel free to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may have missed that
sqlite3_table_column_metadatagets additional metadata for columns, in particularNOT NULLconstraints.Unfortunately because of backwards compatibility a
PRIMARY KEYcolumn is not alwaysNOT NULL, and it's really hard to correctly detectINTEGER PRIMARY KEYcolumns which areNOT NULL.So this misses a few
NOT NULLcolumns, but it's better than nothing, I guess.