Draft
Conversation
- Functions were used without prototypes (clang's -Wdeprecated-non-prototype). - Both wait_stop() and wait_stopnohang() had no definition anywhere, nor were used anywhere.
- Functions were used without prototypes (clang's -Wdeprecated-non-prototype). This exposes new -Wincompatible-pointer-types-discards-qualifiers warnings. - byte_zero() was not defined anywhere nor used anywhere.
Functions were used without prototypes (clang's -Wdeprecated-non-prototype). This exposes new -Wincompatible-pointer-types warnings.
|
@0x5c runit has mix of K&R C (C78) and some ANSI C. I saw in several places, you've used ANSI C like function declaration. Note that this was intentional to use older version of C to make runit compatible as much UNIX-based platforms as it could and generally compiler warnings doesn't necessarily means anything wrong. Compilers are just ahead of time and very old compilers may fail to compile, if they don't satisfy with the standard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building with clang, we get a different set of warnings than with gcc. This is my attempt at fixing them.
-Wdeprecated-non-prototype, exposing previously hidden warnings:-Wincompatible-pointer-types-discards-qualifiersfor byte.h-Wincompatible-pointer-typesfor alloc.h-Wempty-bodyinbuffer_put.crunit/src/buffer_put.c
Line 18 in 2b8000f
It's interesting to see how much has that line spread in the wild.
-Wdeprecated-non-prototypeinbuffer_{get,put}.crunit/src/buffer_put.c
Line 13 in 2b8000f
I also found and removed unused functions that had no implementations.