BaumiCoder/ecformat
1
1
Fork 0
Code Issues 10 Pull requests Releases 3 Packages 2 Activity Actions

Do not collect ConfigFile instances #52

Manually merged
BaumiCoder merged 1 commit from bugfix/Too-many-open-files-via-ConfigFile into main 2026-06-04 18:53:13 +02:00
Conversation 0 Commits 1 Files changed 1 +16 -17
BaumiCoder commented 2026-06-04 17:35:28 +02:00
Owner
Copy link

Bug fix for #38 and #8

User perspective

Fixes a problem with too many open files when process all relevant .editorconfig files for the status command or for the handling of spelling_language in the check command.

Developer perspective

Collecting the ConfigFile instances from ConfigFiles::open in a vector means that all these instances of file handles are open at the same time! This can lead to too many open file handles for the process / system.
A "Too many open files" already occurs on my local machine (not in the CI) when running the tests

files::tests::get_target_files::test_get_target_files_bool_options
files::tests::get_editorconfig_files::test_get_editorconfig_files_bool_options

(However, only if I run all tests and not if I run them separately.)

This problem was introduced with commit 5263ffc.

Bug fix for #38 and #8 ### User perspective Fixes a problem with too many open files when process all relevant `.editorconfig` files for the `status` command or for the handling of `spelling_language` in the `check` command. ### Developer perspective Collecting the ConfigFile instances from ConfigFiles::open in a vector means that all these instances of file handles are open at the same time! This can lead to too many open file handles for the process / system. A "Too many open files" already occurs on my local machine (not in the CI) when running the tests ``` files::tests::get_target_files::test_get_target_files_bool_options files::tests::get_editorconfig_files::test_get_editorconfig_files_bool_options ``` (However, only if I run all tests and not if I run them separately.) This problem was introduced with commit 5263ffc.
Do not collect ConfigFile instances
All checks were successful
/ changes (pull_request) Successful in 52s
Details
/ lint_reuse (pull_request) Successful in 1m13s
Details
/ lint_codespell (pull_request) Successful in 1m7s
Details
/ lint_ecformat (pull_request) Successful in 9m15s
Details
/ test (pull_request) Successful in 5m22s
Details
/ lint_cargo_deny (advisories) (pull_request) Has been skipped
Details
/ lint_cargo_deny (bans licenses sources) (pull_request) Has been skipped
Details
/ lint_clippy (pull_request) Successful in 3m34s
Details
/ lint_rustfmt (pull_request) Successful in 1m58s
Details
/ lint_taplo (pull_request) Has been skipped
Details
/ lint_yamllint (pull_request) Has been skipped
Details
/ lint_cargo_udeps (pull_request) Successful in 22m57s
Details
/ lint_docs_rs (pull_request) Successful in 4m25s
Details
6f84debe23
 
Collecting the ConfigFile instances from ConfigFiles::open in a vector
means that all this instances of file handles are open at the same time!
This can lead to too many open file handles for the process / system.
A "Too many open files" already occurs on my local machine
(not in the CI) when running the tests
files::tests::get_target_files::test_get_target_files_bool_options
files::tests::get_editorconfig_files::test_get_editorconfig_files_bool_options
(However, only if I run all tests and not if I run them separately.)
BaumiCoder manually merged commit 3058d3f1a2 into main 2026-06-04 18:53:13 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
EditorConfig
0.17.2
 Issues to support version 0.17.2 of the EditorConfig specification

  
Kind
Bug
 Something is not working

  
Kind
Chore
 Some tasks maintainig tasks

  
Kind
Documentation
 Documentation changes

  
Kind
Enhancement
 Improve existing functionality

  
Kind
Feature
 New functionality

  
Kind
Testing
 Issue or pull request related to testing

  
Packaging
About packaging the project for some platform

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

  
WIP
Work in progress (Assignee is working on this issue)

No labels
Compat/Breaking
EditorConfig
0.17.2
Kind
Bug
Kind
Chore
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
Testing
Packaging
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
WIP
Milestone
Clear milestone
No items
No milestone
Version 0.2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
BaumiCoder
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
BaumiCoder/ecformat!52
No description provided.