bookstack/system-cli
1
1
Fork 0
Code Issues 1 Pull requests Activity

Changes for v0.3 #21

Closed
danb wants to merge 0 commits from v0.3 into main
pull from: v0.3
merge into: bookstack:main
Conversation 0 Commits - Files changed -
danb commented 2025-03-08 18:26:16 +01:00
Owner
Copy link
  • Adds download-vendor command.
  • Changes mysql usage to use options files, removes use of env options used for password.
  • Updated to use mariadb specific programs if existing, otherwise mysql.
  • Adds common xampp bin path for searching for mysql.
  • Adds detection of CLI file changes during update, and returns early with advisory to re-run if so.
  • Update restore command to now consider system/process env options.

Closes #12, #19, #20, #18

Todo

  • Bump up CLI version
  • Update readme to note new command
  • Run standard tests
  • Test mysql changes where mariadb client connects to mysql.
    • Tested against a 8.0 with --default-authentication-plugin=mysql_native_password. MariaDB and MySQL are becoming more incompatible, so best that the client and server used are aligned.
  • Test DownloadVendorCommand

BookStack doc updates

  • System CLI - Document new download-vendor command.
- Adds `download-vendor` command. - Changes mysql usage to use options files, removes use of env options used for password. - Updated to use mariadb specific programs if existing, otherwise mysql. - Adds common xampp bin path for searching for mysql. - Adds detection of CLI file changes during update, and returns early with advisory to re-run if so. - Update restore command to now consider system/process env options. Closes #12, #19, #20, #18 ### Todo - [x] Bump up CLI version - [x] Update readme to note new command - [x] Run standard tests - [x] Test mysql changes where mariadb client connects to mysql. - Tested against a 8.0 with `--default-authentication-plugin=mysql_native_password`. MariaDB and MySQL are becoming more incompatible, so best that the client and server used are aligned. - [x] Test DownloadVendorCommand ### BookStack doc updates - System CLI - Document new download-vendor command.
- Changes mysql usage to use options files, removes used of env options
  used for password.
- Updated to use mariadb specific programs if existing, otherwise mysql.
- Adds common xampp bin path for searching for mysql.
Added proper detection of CLI changes, with early quite and output to
tell user to re-run, instead of erroring with a stack trace.
Used in scenario where the CLI will change itself as part of BookStack
updates.

Toyed with the idea of pre-compiling CLI PHP files, or handling the
scenario to switch to the new CLI version, but those are a lot more
complex and potentially error prone.
Switched mysql config file use to be an extra file, so that existing
system config files can be considered instead of being ignored.

Does mean that user config files could take precedance, but hopefully
that should not be a big concern.
danb closed this pull request 2025-03-12 00:46:14 +01:00
danb deleted branch v0.3 2025-03-12 01:15:24 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Feature Addition
No labels
Bug
Feature Addition
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: bookstack/system-cli#21
No description provided.
Delete branch "v0.3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?