more permanent fix to start codon regression#415
Draft
TimothyStiles wants to merge 1 commit intomainfrom
Draft
Conversation
Collaborator
Author
|
@carreter there's some issues with it where I had to remove some tests. Will provide more details and ask again for approval before merge. |
|
This PR has had no activity in the past 2 months. Marking as |
|
This PR has had no activity in the past 2 months. Marking as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR
found a regression that was patched with #414 but needs a more permanent solution overall.
Why are you making these changes?
StartCodon handling is somewhat fuzzy.
Are any changes breaking? (IMPORTANT)
No
Pre-merge checklist
primers/primers_test.gofor what this might look like.CHANGELOG.mdin the[Unreleased]section.