Implement KmerTable and BucketKmerTable in Rust#859
Draft
padix-key wants to merge 4 commits intobiotite-dev:rustfrom
Draft
Implement KmerTable and BucketKmerTable in Rust#859padix-key wants to merge 4 commits intobiotite-dev:rustfrom
KmerTable and BucketKmerTable in Rust#859padix-key wants to merge 4 commits intobiotite-dev:rustfrom
Conversation
Merging this PR will not alter performance
Performance Changes
Comparing 
Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
KmerTableandBucketKmerTableare implemented in Cython. However the code is a bit cumbersome, has some degree of code duplication and, since pointer handling is involved, memory safety could pose an issue. All these problems can be mitigated by using a Rust implementation instead.