improve support for dCache as a WebDAV remote#9074
Open
paulmillar wants to merge 1 commit intorclone:masterfrom
Open
improve support for dCache as a WebDAV remote#9074paulmillar wants to merge 1 commit intorclone:masterfrom
paulmillar wants to merge 1 commit intorclone:masterfrom
Conversation
Motivation dCache is open-source software for storing scientific data that provides various enhancements over the standard WebDAV protocol. Modification Add a `dcache` vendor to identify when a WebDAV remote is a dCache instance. Add support for specifying the desired last modification time (mtime) when upload data to dCache. Identify that files' mtime may be used with second granularity. Result rclone can now take advantage of some of the more advanced features that dCache offers. Closes: rclone#8593 Signed-off-by: Paul Millar <[email protected]>
5108d5c to
3370363
Compare
Member
|
This looks very nice :-) Did you run the integration tests to see if they pass? in the |
Contributor
Author
|
Hi @ncw, I ran some manual tests with the patch, to verify it does resolve the problem; however, I didn't run the WebDAV test suite. In fact, running the test suite has identified a handful of problems, even when running an unpatched version of rclone against dCache. My plan is to resolve those issues (as spare time allows) and then retest with the patched version, to check this pull request doesn't introduces any regressions. Just to mention, the first problem looks like a bug in rclone (see #9082). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dCache is open-source software for storing scientific data that provides various enhancements over the standard WebDAV protocol.
Modification
Add a
dcachevendor to identify when a WebDAV remote is a dCache instance.Add support for specifying the desired last modification time (mtime) when upload data to dCache.
Identify that files' mtime may be used with second granularity.
Result
rclone can now take advantage of some of the more advanced features that dCache offers.
Closes: #8593
What is the purpose of this change?
Was the change discussed in an issue or in the forum before?
Checklist