Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Put non-output to sys.stderr #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Put non-output to sys.stderr #217

merged 1 commit into from
Jun 20, 2019

Conversation

shiplu
Copy link
Contributor

@shiplu shiplu commented Jun 13, 2019

There are 2 kinds of print statements.

  1. Progress report. For example "connecting . . .", "binding . . .". This is more like logging and should be put it stderr.
  2. Inspection result of a server method which is used to generate help message. Such help messages should also be in stderr.

The benefit is we can pipe the method output to other commands or redirect it to files without adding invalid log lines.

@shiplu
Copy link
Contributor Author

shiplu commented Jun 20, 2019

@bombela I have applied the changes suggested by you. Would you review this again?

@bombela bombela merged commit 276f05e into 0rpc:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants