core: handle both "async" and "asynchronous" in remote calls #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can always pass What not name the new argument "async_". And also add it to the named argument list directly. This helps for type checking and other linting tools. |
Python 3.7 made "async" a reserved keyword: this causes a syntax error when passing "async" as a named parameter in remote procedure calls. Make ClientBase.__call__() understand both "async" and "async_" so we don't break our binary interface with older clients. Fixes: 0rpc#239 Signed-off-by: Cedric Hombourger <[email protected]>
renamed |
|
You are absolutely correct. The function is clearly not taking explicit parameters. Let's not change that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.7 made "async" a reserved keyword: this causes a syntax
error when passing "async" as a named parameter in remote procedure
calls. Make ClientBase.call() understand both "async" and
"asynchronous" so we don't break our binary interface with older
clients.
Fixes: #239
Signed-off-by: Cedric Hombourger [email protected]