Thanks to visit codestin.com
Credit goes to github.com

Skip to content

use logging instead of printing to stderr #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2013
Merged

use logging instead of printing to stderr #68

merged 1 commit into from
Oct 24, 2013

Conversation

wiggin15
Copy link
Contributor

printing to stderr makes test output harder to read. using the logging module instead fixes this and also allows the developer to control if and when the zerorpc errors are printed.

@bombela
Copy link
Member

bombela commented Jul 11, 2013

thank you for the contribution. I will merge later, when I have time to test everything.

@jpetazzo
Copy link
Contributor

+1 on using standard logging instead of prints to stderr!

On Thu, Jul 11, 2013 at 1:44 PM, François-Xavier Bourlet <
[email protected]> wrote:

thank you for the contribution. I will merge later, when I have time to
test everything.


Reply to this email directly or view it on GitHubhttps://github.com//pull/68#issuecomment-20840866
.

bombela added a commit that referenced this pull request Oct 24, 2013
use logging instead of printing to stderr
@bombela bombela merged commit 1ec405c into 0rpc:master Oct 24, 2013
@wiggin15 wiggin15 deleted the logging branch October 24, 2013 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants