This repository was archived by the owner on Dec 25, 2025. It is now read-only.
Remove link to (redundant) es6-string-css#50
Merged
0x00000001A merged 1 commit into0x00000001A:masterfrom Aug 8, 2022
Merged
Conversation
Since v2.9.0 (854ca54) 0x00000001A#39 CSS language is included – this makes the es6-string-css link redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v2.9.0 (854ca54) – issue #39 – the CSS language is built in to core: this makes the
es6-string-csscommunity link redundant.I installed the
es6-string-cssextension while reading the README in the marketplace, assuming it was a useful suggestion (and missing the fact that CSS was already included in core). Earlier I was hacking ates6-string-csssource and reloading my VS Code window to see the effects… but the changes I was iterating weren't manifesting. It took me a while to realise the reason was thates6-string-htmlwas taking precedence 😅I think it would be good to remove the suggestive mention from the README, since it's redundant and potentially confusing. Since these community plugins are essentially unintegrated patches, wouldn't it make sense to simply patch them in if desirable? There's already a lot of redundancy in the VS Code extensions marketplace, and any improvements / community suggestions ought to be centralised here IMO.
Thanks for the plugin BTW – I'm doing some remote procedure calls with an 'everything-in-JS' approach, and this really helps see code functionality at a glance 🙇♂️