Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ethyla
Copy link
Contributor

@ethyla ethyla commented Nov 15, 2024

  • Removes:
    • old upgrade scripts
    • auction mechanism in StakeManager
    • outdated docs
    • old linter (solium) and formater (prettier)
    • various outdated files/configs
    • last pieces of slashing
    • outdated predicates
    • unneeded deps
  • Adjusts:
    • tests to changed files
    • linter to solhint
    • init of StakeManager
    • pol and matic tests now behave the same in StakeManager
    • move unsupported OZ contracts into repo
    • use same import style everywhere

@ZeroEkkusu ZeroEkkusu requested a review from Copilot November 18, 2024 14:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 192 out of 210 changed files in this pull request and generated no suggestions.

Files not reviewed (18)
  • .env.example: Language not supported
  • .gitattributes: Language not supported
  • .nvmrc: Language not supported
  • .prettierrc: Language not supported
  • .solhint.json: Language not supported
  • .soliumignore: Language not supported
  • .soliumrc.json: Language not supported
  • broadcast/UpgradeDepositManager_Sepolia.s.sol/11155111/run-1721057237.json: Language not supported
  • broadcast/UpgradeDepositManager_Sepolia.s.sol/11155111/run-latest.json: Language not supported
  • broadcast/UpgradeStakeManager_Sepolia.s.sol/11155111/run-1721057742.json: Language not supported
  • broadcast/UpgradeStakeManager_Sepolia.s.sol/11155111/run-latest.json: Language not supported
  • broadcast/UpgradeStake_DepositManager_Mainnet.s.sol/1/run-1724288447.json: Language not supported
  • contracts/common/misc/ContractReceiver.sol: Language not supported
  • contracts/common/misc/DrainStakeManager.sol: Language not supported
  • contracts/root/IRootChain.sol: Language not supported
  • contracts/root/RootChain.sol: Language not supported
  • contracts/staking/slashing/ISlashingManager.sol: Language not supported
  • contracts/staking/slashing/SlashingManager.sol: Language not supported

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@ethyla ethyla changed the title WIP: feat/housekeeping feat/housekeeping Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants