Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DON'T MERGE: tmp/log increase #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

DON'T MERGE: tmp/log increase #31

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1409eed
feat: remove log limit
ethyla May 23, 2025
5c42298
faet: add paylaod script
ethyla May 26, 2025
b342ce8
fix: relax some checks
ethyla Jun 26, 2025
ee0f28c
fix: extend and improve script
ethyla Jun 26, 2025
2c5df78
feat: only allow timelock to call
ethyla Jul 3, 2025
d9b179a
feat: fork test
ethyla Jul 4, 2025
e09460b
fix: add extra check
ethyla Jul 7, 2025
5b54115
fix: exit funds
ethyla Jul 21, 2025
e13029a
feat: revert on all writable fn
ethyla Jul 21, 2025
f4c3929
fix: set called true
ethyla Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions contracts/root/predicates/ERC20PredicateBurnOnly.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@ contract ERC20PredicateBurnOnly is IErcPredicate {
ExitPayloadReader.ExitPayload memory payload = data.toExitPayload();
ExitPayloadReader.Receipt memory receipt = payload.getReceipt();
uint256 logIndex = payload.getReceiptLogIndex();
require(logIndex < MAX_LOGS, "Supporting a max of 10 logs");
//require(logIndex < MAX_LOGS, "Supporting a max of 10 logs");
// Alternative example :
//require(logIndex < 50, "Supporting a max of 50 logs");

uint256 age = withdrawManager.verifyInclusion(
data,
0, /* offset */
Expand All @@ -48,24 +51,17 @@ contract ERC20PredicateBurnOnly is IErcPredicate {
ExitPayloadReader.LogTopics memory topics = log.getTopics();
// now, inputItems[i] refers to i-th (0-based) topic in the topics array
// event Withdraw(address indexed token, address indexed from, uint256 amountOrTokenId, uint256 input1, uint256 output1)
require(
bytes32(topics.getField(0).toUint()) == WITHDRAW_EVENT_SIG,
"Not a withdraw event signature"
);
require(
msg.sender == address(topics.getField(2).toUint()), // from
"Withdrawer and burn exit tx do not match"
);
require(bytes32(topics.getField(0).toUint()) == WITHDRAW_EVENT_SIG, "Not a withdraw event signature");
// Need to skip this check because we aren't the exitor
// require(
// msg.sender == address(topics.getField(2).toUint()), // from
// "Withdrawer and burn exit tx do not match"
// );
address rootToken = address(topics.getField(1).toUint());
uint256 exitAmount = BytesLib.toUint(log.getData(), 0); // amountOrTokenId
// Need to pass in the actual exitor here, not msg.sender
withdrawManager.addExitToQueue(
msg.sender,
childToken,
rootToken,
exitAmount,
bytes32(0x0),
true, /* isRegularExit */
age << 1
address(topics.getField(2).toUint()), childToken, rootToken, exitAmount, bytes32(0x0), true, /* isRegularExit */ age << 1
);
}

Expand Down
Loading