Add support for cargo #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently don't have the test passing for importing credentials from a file, working on that now.
volodymyrZotov
requested changes
Jan 10, 2023
Contributor
|
Hey @accraw ! Thank you for your contribution! I reviewed your PR and added some comments that might help you to fix the tests and finalize the PR. |
florisvdg
reviewed
Jan 10, 2023
volodymyrZotov
previously approved these changes
Jan 11, 2023
florisvdg
reviewed
Jan 11, 2023
florisvdg
approved these changes
Jan 11, 2023
volodymyrZotov
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently don't have the test passing for importing credentials from a file, working on that now.
If I change [registry] to [[registry]] it passes, but that's not how the file is created by cargo.
Resolves #81