-
Notifications
You must be signed in to change notification settings - Fork 242
New plugin: SnowSQL #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New plugin: SnowSQL #161
Conversation
…for snowsql file importer
arunsathiya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start! I left some comments to improve the importing flow for your consideration.
SimonBarendse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Snowflake will make for a great addition to the ecosystem!
Arun made some great suggestions in his review. I don't have much to add to that.
|
Updated the testing instructions based on recent feedback on the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only one comment, otherwise this is good to go, code-wise.
Thank you for this addition, @williamhpark ! ❤️
fc02c19
Summary
Add support for a new plugin for the Snowflake CLI, SnowSQL.
Addresses: #154
Testing
Setup
make snowflake/buildImporter
~/.snowsql/config. Add your Snowflake credentials to this file under[connections]. Initialize the SnowSQL plugin and test the importer using this config file. The credentials should be saved in 1Password successfully. Note: By default, the~/.snowsql/configfile has a[connections]section where the actual credentials are stored, as well as an uncommented[connections.example]section where example credentials are displayed. No matter where[connections.example]is located and even if the example credentials are uncommented, only the true credentials under[connections]should ever be saved by the importer.Provisioner
snowsqlcommand (justsnowsqlshould suffice, but if you want to add connection parameters the available ones are listed here). You should be taken through the authentication flow with the SnowFlake Credentials that were saved in 1Password, and you shouldn't have to enter the credentials manually. Once authenticated, you should enter the SnowSQL shell, from which you can interact with your Snowflake warehouses/databases.snowsqlcommand with each of the following arguments (descriptions can be found here):You should not be prompted to authenticate through the 1Password CLI.
Note: While testing the provisioner, ensure that your credentials are not currently stored in
~/.snowsql/confignor environment variables.Additional Information
snowflakeand the executable name issnowsql.